Skip to content

chore: removed inactive sources#965

Merged
egordidenko merged 2 commits intomainfrom
chore/inactive-sources
May 6, 2026
Merged

chore: removed inactive sources#965
egordidenko merged 2 commits intomainfrom
chore/inactive-sources

Conversation

@egordidenko
Copy link
Copy Markdown
Contributor

@egordidenko egordidenko commented May 1, 2026 •
edited by coderabbitai Bot
Loading

Description

Checklist

Summary by CodeRabbit

  • Chores
    • Removed support for uploading from Flickr, VK, Evernote, and Huddle.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 1, 2026 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • specs/npm/__snapshots__/npm.test.ts.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 682f352f-ebaa-4216-bb10-07fcf0b8c9ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Four external upload source constants (FLICKR, VK, EVERNOTE, HUDDLE) were removed from the ExternalUploadSource object in src/utils/UploadSource.ts, which automatically updates the derived SourceTypes union type to exclude the corresponding members.

Changes

Cohort / File(s) Summary
Upload source constants removal
src/utils/UploadSource.ts		 Removed four constants (FLICKR, VK, EVERNOTE, HUDDLE) from ExternalUploadSource object; corresponding union members automatically removed from SourceTypes derived type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Four sources hop away today,
From upload's bustling display,
FLICKR, VK fade to gray,
EVERNOTE and HUDDLE won't stay—
Cleaner code in every way! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is completely empty except for the template structure; it contains no issue link, change description, code snippets, or checklist items filled out. Fill in the description with: a link to the related issue, a brief explanation of why these sources are inactive, and check applicable checklist items based on whether tests or documentation changes are needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: removed inactive sources' clearly and concisely describes the main change: removal of unused upload source constants from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/inactive-sources

Comment @coderabbitai help to get the list of available commands and usage tips.

@egordidenko egordidenko merged commit da686aa into main May 6, 2026
7 checks passed
@egordidenko egordidenko deleted the chore/inactive-sources branch May 6, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nd0ut nd0ut nd0ut approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@egordidenko @nd0ut